Update Package.swift to support Swift 5 #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref: SE-0236 |
ikesyo
requested changes
Mar 29, 2019
There was a problem hiding this comment.
Please restore the backward compatibility with Swift 4.2 as same as Quick/Quick#843 (this commit).
houndci-bot
reviewed
Mar 31, 2019
devxoul
force-pushed
the
swift-5
branch
2 times, most recently
from
c261973 to
71aaeab
Compare
|
@ikesyo Done! |
wongzigii
approved these changes
Apr 2, 2019
ikesyo
approved these changes
Apr 2, 2019
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Update Package.swift to support Swift 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As upgrading to Swift 5, without having
platformsthe default deployment target is set to the latest version of each OS. It causes a compile error.platforms.v5toswiftLanguageVersions(The description is same with Quick/Quick#843)